Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArmoredChat notifications on join and leave #1203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ArmoredChat notifications on join and leave #1203

wants to merge 2 commits into from

Conversation

Armored-Dragon
Copy link
Member

Adds an optional notification to join and leave notifications powered by notification core.

image

Closes #1197

@Armored-Dragon Armored-Dragon added enhancement New feature or request needs CR This pull request needs to be code reviewed QA approved This pull request has been successfully tested labels Oct 28, 2024
@Armored-Dragon Armored-Dragon self-assigned this Oct 28, 2024
ksuprynowicz
ksuprynowicz approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksuprynowicz ksuprynowicz ksuprynowicz approved these changes

Assignees

@Armored-Dragon Armored-Dragon

Labels
CR approved This pull request has been successfully code reviewed enhancement New feature or request QA approved This pull request has been successfully tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add (preferably optional) notification when someone joins or leaves
2 participants
@Armored-Dragon @ksuprynowicz